Skip to content

#13 Fixes inconsistency in generating legal product IDs between the M… #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danemacmillan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#13 Fixes inconsistency in generating legal product IDs between the M… #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Helper/Data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public function getProductId($product)
$rawProductId = $product;

/** Customizations go here */
$rawProductId = preg_replace_callback('/\./s', create_function('$match', 'return "_bv".ord($match[0])."_";'), $rawProductId);

/** No further customizations after this */

return $this->replaceIllegalCharacters($rawProductId);
Expand All @@ -131,7 +131,7 @@ public function replaceIllegalCharacters($rawId)
* Example encoded = qwerty_bv36__bv37__bv64__bv35_asdf
*/

return preg_replace_callback('/[^\w\d\*-\-_]/s', create_function('$match', 'return "_bv".ord($match[0])."_";'), $rawId);
return preg_replace_callback('/[^\w\d\*-\-\._]/s', create_function('$match', 'return "_bv".ord($match[0])."_";'), $rawId);
}


Expand Down