Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pypi): mark the extension reproducible #2730

Merged
merged 4 commits into from
Apr 5, 2025

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Apr 2, 2025

This will remove the merge conflicts and improve the usability when the
MODULE.bazel.lock is used together with rules_python. This means
that the lock file will not be used to read the URL and sha256
values for the Python sources when the experimental_index_url is used,
but the idea is that that information will be kept in repo cache.

Fixes #2434

Created #2731 to leverage the bazel feature to write immutable facts to
the lock file once it becomes available.

This will remove the merge conflicts and improve the usability when the
`MODULE.bazel.lock` is used together with `rules_python`. This means
that the lock file will not be used to read the `URL` and `sha256`
values for the Python sources when the `experimental_index_url` is used,
but the idea is that that information will be kept in repo cache.

Fixes bazel-contrib#2434
@aignas aignas requested review from rickeylev and groodt as code owners April 2, 2025 14:56
@aignas aignas added this pull request to the merge queue Apr 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 5, 2025
@aignas aignas enabled auto-merge April 5, 2025 16:12
@aignas aignas added this pull request to the merge queue Apr 5, 2025
Merged via the queue into bazel-contrib:main with commit 2bc3577 Apr 5, 2025
3 checks passed
@aignas aignas deleted the fix/2434-repro branch April 5, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid merge conflicts in MODULE.bazel.lock
2 participants