[googletest] avoid -lpthread link option when building with emscripten without threads #5992
Conversation
|
Hello @derekmauro, modules you maintain (googletest) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new patched version, 1.17.0.bcr.1, for the googletest module. The patch correctly avoids the -lpthread link option when building with Emscripten without thread support. The changes align well with the Bazel Central Registry's contribution guidelines. However, I've identified a critical issue regarding a dependency version mismatch for abseil-cpp, which could lead to build or runtime failures for transitive dependencies. My review includes a specific comment and a suggested fix for this issue.
DoDoENT
force-pushed
the
fix/google-test-emscripten-no-threads
branch
from
c5ff50b to
b13eb2e
Compare
…n without threads (bazelbuild#5992) I also created an [upstream PR](google/googletest#4824) for this change.
4 participants
I also created an upstream PR for this change.