Conversation
A caller can observe the marker before a prior materialization finishes but submit work after TaskDeduplicator forgets the completed operation. Recheck marker presence inside the per-key supplier to avoid submitting a second operation that writes a missing marker. A deterministic regression reproduces the null pointer on the old code and passes with the recheck. Joined-task failures still propagate.
github-actions
Bot
added
team-Remote-Exec
fmeum
approved these changes
Sep 19, 2026
Collaborator
|
@bazel-io fork 9.3.0 |
github-actions
Bot
added
the
community-reviewed
tjgq
approved these changes
Sep 21, 2026
tjgq
added
copybara:import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recheck repository marker presence inside
TaskDeduplicator's per-key supplier: another caller may finish materialization after the initial check but before task submission. This prevents a duplicate operation from writing a missing marker and crashing; callers joining an active operation still receive its result.RELNOTES: None