Conversation
When no dirty dependency group has been consumed, the existing GroupedDeps element count is the exact capacity needed for the remaining-dependency set. Use it to avoid growing and rebuilding the ImmutableSet builder. Keep the default builder for partial suffixes so they do not allocate for already-consumed dependencies. Traversal and position updates are unchanged.
github-actions
Bot
added
the
awaiting-review
fmeum
approved these changes
Sep 20, 2026
github-actions
Bot
added
the
community-reviewed
justinhorvitz
approved these changes
Sep 21, 2026
iancha1992
added
the
team-Configurability
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-size
getAllRemainingDirtyDirectDeps'sImmutableSetbuilder fromGroupedDeps.numElements()when no dependency groups have been consumed, retaining default allocation for partial suffixes.On a representative large build we reduce total bytes allocated (from a baseline of 240GB) by 2%, which should help GC pressure a bit.
RELNOTES: None