Conversation
Six other cases of external_integration_test create an archive with exactly the same contents. Zip stores modification times with a granularity of two seconds, so when two of them run within the same second in different shards, the archives are byte-identical and thus have the same checksum. Every shard on a CI machine shares the same repository cache, so as soon as the other case has fetched its copy, the build without `--distdir` in this test finds the archive in the cache and succeeds although it is expected to fail. Add a file with the test's own temporary directory to the archive so that no other test or attempt can have cached it.
fmeum
marked this pull request as ready for review
September 22, 2026 18:23
github-actions
Bot
added
the
awaiting-review
meteorcloudy
approved these changes
Sep 23, 2026
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Six other cases of
external_integration_testcreate an archive with exactly the same contents astest_distdir_option_not_sticky. Zip stores modification times with a granularity of two seconds, so when two of them run within the same second in different shards, the archives are byte-identical and thus have the same checksum. Every shard on a CI machine shares the same repository cache, so as soon as the other case has fetched its copy, the build without--distdirin this test finds the archive in the cache and succeeds although it is expected to fail.The test now adds a file with its own temporary directory to the archive so that no other test or attempt can have cached it.
Motivation
test_distdir_option_not_stickyfailed on the first attempt of a Linux shard of #31263 and passed on the retry, and it fails the same way locally when all shards of the test start at the same time with a sharedREPOSITORY_CACHE. The build that is expected to fail fetches the repo without any download, which is only possible with a repository cache hit.Build API Changes
No
Release Notes
RELNOTES: None