Skip to content

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Aug 1, 2025

Discussion thread for this change

Issue number: #6812

Description of this change

This PR addresses multiple issues with argument parsing and extends the execution headless test to also debug run configurations.

  • removes manual escaping of inferior arguments in the gdbserver script, because since 2020 gdbserver does this automatically
  • collect and forward args defined in the BUILD file when using LLDB
  • fixes index out of bound exception for empty user defined arguments

@LeFrosch LeFrosch force-pushed the pull/2175288495d2de56639ae93ca0793a06a58b9456 branch from 2175288 to 5e30ebb Compare August 1, 2025 15:02
@kekxv
Copy link

kekxv commented Aug 20, 2025

@LeFrosch When is the release planned?

@LeFrosch LeFrosch marked this pull request as ready for review September 4, 2025 08:20
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Sep 4, 2025
@ujohnny
Copy link
Collaborator

ujohnny commented Sep 4, 2025

So if we understand the gdbserver changes right, this change could break gdbserver < 10.1, so probably we would like to put a version detection and use the previous logic for old gdbserver versions

Conditionally enable shell escaping for inferior arguments if gdbserver version is less then 10.1
@LeFrosch LeFrosch merged commit e7aa7f5 into bazelbuild:master Sep 17, 2025
3 checks passed
@LeFrosch LeFrosch deleted the pull/2175288495d2de56639ae93ca0793a06a58b9456 branch September 17, 2025 15:27
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Bazel IntelliJ Plugin Sep 17, 2025
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

5 participants