Skip to content

Conversation

@LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Feb 9, 2026

Next step of finally phasing out any querysync specific implementations. We only use on of the BEP parser definitions i.e. we only use the "legacy" implementations, thus we can remove the new querysync specific implementations and only keep the one required for the aspect sync.

This removes friction for future changes to the BEP infrastructure.

@gemini-code-assist
Copy link

Summary of Changes

Hello @LeFrosch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the codebase by removing querysync-specific implementations related to BEP parsing and inlining the legacy definitions. This simplifies the BEP infrastructure, making future changes easier to implement and maintain. The MODULE.bazel.lock file is also updated to align with the modified dependencies.

Highlights

  • Inline Legacy BEP Parser Definitions: This PR streamlines the codebase by inlining legacy BEP parser definitions, removing querysync-specific implementations.
  • Reduces Friction: The change aims to reduce friction for future modifications to the BEP infrastructure.
  • MODULE.bazel.lock Update: Updates the MODULE.bazel.lock file to reflect changes in module dependencies and versions.
Changelog
  • MODULE.bazel.lock
    • Updates module dependencies and versions.
    • Removes outdated module entries.
    • Adds new module entries for buildifier, buildozer, protobuf, rules_apple, rules_bazel_integration_test, rules_cc, rules_java, rules_python, rules_swift, and swift_argument_parser.
    • Modifies module extension configurations, updating digests and recorded inputs.
Activity
  • Removes querysync specific implementations from BEP parser definitions.
  • Updates the MODULE.bazel.lock file to reflect dependency changes.
  • Simplifies the BEP infrastructure for future modifications.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great cleanup, removing the legacy BEP parser definitions and unifying the implementation. The changes are consistent and well-executed across the codebase, simplifying the class hierarchy around BlazeBuildOutputs and ParsedBepOutput. I have one minor suggestion for improving encapsulation in BlazeBuildOutputs.

@LeFrosch LeFrosch marked this pull request as ready for review February 9, 2026 14:50
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Feb 9, 2026
@LeFrosch LeFrosch merged commit 63021c6 into bazelbuild:master Feb 9, 2026
7 checks passed
@LeFrosch LeFrosch deleted the pull/5e82acefe468a0e0480dc0c28b10a4ce104af89d branch February 9, 2026 17:14
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Bazel IntelliJ Plugin Feb 9, 2026
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin

Projects

Development

Successfully merging this pull request may close these issues.

4 participants