chore(clean up): remove DelegatingBlazeProjectDataManager

[LeFrosch]

The DelegatingBlazeProjectDataManager was required to switch between the two ProjectDataManager implementations, which is no longer required since we removed querysync.

[gemini-code-assist]

Summary of Changes

Hello @LeFrosch, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's data management by eliminating the DelegatingBlazeProjectDataManager. This delegation layer is no longer necessary following the removal of the querysync feature, allowing for a direct and simpler integration of the AspectSyncProjectDataManager.

Highlights

• Removal of Delegation: The DelegatingBlazeProjectDataManager class, which previously handled switching between different ProjectDataManager implementations, has been completely removed from the codebase.
• Direct Implementation: The BlazeProjectDataManager service in blaze-base.xml now directly uses AspectSyncProjectDataManager as its implementation, simplifying the project data management setup.
• Reason for Change: This cleanup is a direct result of the querysync feature being removed, which was the sole reason for the DelegatingBlazeProjectDataManager's existence.

Changelog

• base/src/META-INF/blaze-base.xml
  • Updated the projectService implementation for BlazeProjectDataManager from DelegatingBlazeProjectDataManager to AspectSyncProjectDataManager.
• base/src/com/google/idea/blaze/base/sync/data/DelegatingBlazeProjectDataManager.java
  • The entire file, containing the DelegatingBlazeProjectDataManager class, has been deleted.

Activity

• The pull request was initiated by LeFrosch with the title "chore(clean up): remove DelegatingBlazeProjectDataManager".
• The author's description clarifies that the DelegatingBlazeProjectDataManager was removed because it was only needed for switching between ProjectDataManager implementations, a requirement that ceased with the removal of querysync.
• No further review comments or activity have been recorded.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request performs a clean refactoring by removing the DelegatingBlazeProjectDataManager. This class acted as a layer to switch between different ProjectDataManager implementations based on the project type. With the removal of query-sync support, this delegation logic is no longer necessary. The change correctly updates the service definition in blaze-base.xml to use AspectSyncProjectDataManager directly and removes the now-redundant DelegatingBlazeProjectDataManager class. This is a good simplification that improves code clarity and maintainability.