RFC: proc_macro self-transition #3595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
force-pushed
the
zbarsky/proc-macros-2
branch
from
7e5c4bc to
f3ba350
Compare
dzbarsky
commented
Sep 6, 2025
| @@ -1072,6 +1048,21 @@ rust_shared_library = rule( | |||
| """), | |||
| ) | |||
|
|
|||
| def _exec_transition_impl(_settings, attr): | |||
| return { | |||
| "//command_line_option:is exec configuration": not attr.internal_doctest_transition_override, | |||
There was a problem hiding this comment.
wasn't sure if there was a cleaner way to do this, hacking around a failure in the doctest
Executing tests from //test/unit/rustdoc:rustdoc_proc_macro_doctest
-----------------------------------------------------------------------------
error[E0463]: can't find crate for `std`
|
= note: the `aarch64-apple-darwin` target may not be installed
= help: consider downloading the target with `rustup target add aarch64-apple-darwin`
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0463`.
|
Let's take #3605 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.