Repository navigation
feat(popup-menu): exempt an external element from outside press - #525
Merged
Conversation
kianbazza
added this pull request to stack #526
September 28, 2026 22:53
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kianbazza
force-pushed
the
ui-555-exempt-an-external-element-from-outside-press
branch
from
September 28, 2026 23:00
8b0bdb6 to
e79db15
Compare
kianbazza
force-pushed
the
ui-555-exempt-an-external-element-from-outside-press
branch
from
September 29, 2026 14:29
e79db15 to
02dd46c
Compare
kianbazza
marked this pull request as ready for review
September 29, 2026 14:45
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usePopupMenuRootacceptsgetDismissExemptElements: elements outside the menu that don't dismiss it when pressed or when focus moves to them. The suggestion menu passes its host input, so clicking the field doesn't close its menu.Two mechanisms dismiss a menu, and both respect the exemption:
Evidence
New
use-popup-menu-root.outside-press.test.tsx:Merge Danger
Door: two-way
Blast Radius: none
No member passes exempt elements yet.
Closes UI-555