Repository navigation
feat(suggestion-menu): add a noResults option - #535
Merged
Conversation
kianbazza
added this pull request to stack #526
September 29, 2026 01:44
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kianbazza
force-pushed
the
ui-564-add-a-no-results-option-to-the-suggestion-menu
branch
from
September 29, 2026 14:29
6c48291 to
d557c1d
Compare
kianbazza
marked this pull request as ready for review
September 29, 2026 14:45
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
noResultstoSuggestionMenu.Root.'empty'(the default): the menu stays open and showsEmpty, and Enter reaches the host.'close': the menu closes once every search for the query has finished empty (reason'no-results'). It closes before the empty popup is painted.update()with the same query leaves it closed, for example when only the caret moved.querythat renders after theupdate()still reopens the menu.SuggestionMenu.useAsyncMenuCoordinatoris available for a "searching…" indicator while results refetch.Evidence
suggestion-menu.no-results.test.tsx(14 tests):close()and changing the host forget the empty query.Checked in Chromium with ProseMirror:
/qzcloses withno-results, and Backspace to/qreopens with "Quote".Merge Danger
Door: two-way
Blast Radius: SuggestionMenu, plus a new shared
'no-results'reasonCloses UI-564