Repository navigation
Conversation
kianbazza
added this pull request to stack #572
September 29, 2026 15:05
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Adds `bun run lint:exceptions`, which lists every allowlisted file by rule, the rules turned off by pattern, and every inline lint exception with its reason. CI runs it after oxlint and adds the list to the job summary. It fails only on a malformed exception, which catches a bare `oxlint-disable` that has silenced the rule meant to report it.
kianbazza
force-pushed
the
ui-619-report-lint-exceptions-in-ci
branch
from
September 29, 2026 15:08
1c442f4 to
02e1ca2
Compare
kianbazza
marked this pull request as ready for review
September 29, 2026 15:41
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun run lint:exceptionslists every lint exception inpackages/react. CI runs it after oxlint, even if oxlint failed, and adds the list to the job summary.bazza/*exception, oreslint-disable. Everything else is informational, a burn-down list./* oxlint-disable */on a file's first line silences every rule, includingbazza/disable-needs-reason, which is the rule meant to report it. This script reads the text, so nothing can silence it.eslint-disablein a file already allowlisted forbazza/disable-needs-reasonis listed but doesn't fail, because oxlint ignoreseslint-*comments. A malformedoxlint-disablefails even in that file.tooling/lint/source-text.ts) that skips strings and template literals and copes with apostrophes in JSX text. The same module parses.oxlintrc.jsonas JSONC for both the report and the lint tests.Evidence
packages/reactfile whose first line is/* oxlint-disable */passedbun run checkand CI, with every rule silenced for the whole file.After:
data-list.tsx, and after<p>Don't</p>on the same line. On the current tree it exits 0.tooling/linttests grow to 73. They cover the tokenizer (URLs, globs, template literals, JSX apostrophes, unclosed quotes, escaped newlines), JSONC parsing, allowlist and pattern detection (including the'allow',0and['off', …]levels), the exemption rule, and a check that every allowlisted file in the repo config exists.Merge Danger
Door: two-way
Blast Radius: CI
This adds one CI step. It fails a PR only when that PR adds a malformed lint exception comment in
packages/react.Closes UI-619