IMSC.js Styling #95
Open
IMSC.js Styling #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelmegitt
reviewed
Apr 28, 2025
package.json
Outdated
| "localforage": "^1.7.1", | ||
| "path-browserify": "^1.0.1", | ||
| "ua-parser-js": "^1.0.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "imsc": "^1.1.4" |
There was a problem hiding this comment.
Hi @nigelmegitt, we are using the latest BBC smp-imsc fork for this. However, it's swapped out in Bigscreen player rather than here — so I've reverted the change here to avoid it being in the bundle twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
bbc/ImscJScustomisation options to the Dash.js settings in a way consistent with other subtitle settings already within Dash.js.bbc/ImscJScustomisation has been already been PR'd back to mainlinesandflow/imscJS#257. However, there hasn't been any indication when this may be merged.The changes here are compatible with those proposed to mainline
sandflow/imscJSshould the PR be merged.These changes are required to allow customisation of subtitles on TV Platforms through Bigscreen Player for an upcoming low-latency trial. As the content is delivered in chunks for low-latency DASH it is would not be possible to use the existing side-chain mechanism in BSP without significant modification.