feat: rework ExpectedPackages generation/management to add PieceInstances as owners to existing docs #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
force-pushed
the
feat/expected-packages-multiple-ingest-owners
branch
from
711c07a to
7265685
Compare
Julusian
force-pushed
the
feat/expected-packages-shared-ingest-and-playout
branch
from
f63c164 to
747763c
Compare
Julusian
force-pushed
the
feat/expected-packages-multiple-ingest-owners
branch
2 times, most recently
from
18918d4 to
8ebf2a2
Compare
…nces as owners to existing docs
Julusian
force-pushed
the
feat/expected-packages-shared-ingest-and-playout
branch
from
747763c to
2d03007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP SOFIE-241
Continues #54
For upstream:
This does leave an existing case of statuses when a bucket adlib is played. Because the ExpectedPackages are owned by either a rundown or a bucket, they do not benefit from the immediate status availability.
However, in my testing the flow is smoother than before.
Testing current release53, when playing a bucket adlib, it takes ~15s for the statuses to be available. Each time the adlib is played this delay occurs (even within the same partinstance).
With this PR, it is now taking <5s (I am unsure why, I don't know why that would have changed). And future plays of the adlib have statuses immediately. This latter part is due to the stable id of the packages, and benefits from the delayed cleanup of statuses.