Skip to content

Replace ts-node with the TypeScript language service #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

paulbrimicombe
Copy link
Collaborator

Addresses #34

Problem

  • OOM errors when compiling large numbers of snippets
  • This appears to be due to caching etc. in the ts-node package

Solution

  • Drop ts-node completely and use the TypeScript Language service directly (this is what ts-node does under the hood)
  • Don't write snippets to disk.
  • Compile snippets in series instead of parallel
    • I suspect most of the work is CPU rather than I/O so parallelism doesn't actually help much with the compilation time
    • If we really want to parallelise the compilation, we should probably look at workers etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant