-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP, Move to sdk/v3 and go-client/v4 #22
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexander Bezzubov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of the change looks good! Not approving yet, since there are few more points in the TODO list.
|
||
// Tokenizer sub-command outputs every token to STDOUT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this won't work as one may expect. Tokens are missing for some structures.
Co-Authored-By: Denys Smirnov <[email protected]>
Co-Authored-By: Denys Smirnov <[email protected]>
As much as I would love to finish this work that have taught me a lot - I do not think I'll have time for it in next few weeks, so removing myself from assignment for now. |
Progress
it, _ := tools.Filter(n, "./*")
only visits the root node)This change is