Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add number of improvements to the label maker standard sketch #1

Draft
wants to merge 26 commits into
base: base
Choose a base branch
from
Draft

Add number of improvements to the label maker standard sketch #1

wants to merge 26 commits into from

Conversation

bboe
Copy link
Owner

@bboe bboe commented Dec 4, 2024 •
edited
Loading

The first three commits on this PR are simply clean-up and some organization to make following along with the subsequent commits easier.

Notable changes:

  • Enable joystick up/down to wrap around the beginning/end of the character selection
  • Combine alphabet characters and their vectors into a single structure
  • Fix bug where current character replaces previous character on backspace
  • Use LCD's built-in blink support
  • Display text to be printed on the print menu, and blink the character currently being printed
  • Simplify variable-width character support
  • Reduce SRAM (memory) usage from 83% to 30% primarily by using F(...) for strings and PROGMEM for the array of character/vector structures

For comparison the output from compilation before these improvements:

Sketch uses 14496 bytes (44%) of program storage space. Maximum is 32256 bytes.
Global variables use 1714 bytes (83%) of dynamic memory, leaving 334 bytes for local variables. Maximum is 2048 bytes.

And the output after these improvements:

Sketch uses 11584 bytes (35%) of program storage space. Maximum is 32256 bytes.
Global variables use 633 bytes (30%) of dynamic memory, leaving 1415 bytes for local variables. Maximum is 2048 bytes.

@bboe bboe force-pushed the label_maker_standard_improvements branch from e3fdf8a to 9bf76f3 Compare December 8, 2024 18:16
@bboe bboe changed the base branch from main to base December 8, 2024 21:25
@bboe bboe force-pushed the label_maker_standard_improvements branch from 9bf76f3 to dcb41b5 Compare December 9, 2024 01:07
bboe added 8 commits December 8, 2024 22:22
@bboe
Remove unused variables, and methods, and commented out code
7584c5a
@bboe
Organize globals, and other clean up
3f2d97d 
Rename:
- line to plotLine
- plot to setPen

Normalize X/Y variables to termX, termY

Add additional define constants

Remove unused conditional pertaining to dashed drawing
@bboe
Sort functions
8ee25b3
@bboe
Enable label maker text up/down input to wrap around
6cd7402
@bboe
Explain octal values and format vector comments consistently
08d9fe2
@bboe
Use a struct in labelmaker to hold alphabet for simplicity
73b926e 
As part of this change, use a fixed-width character array to hold chosen
characters, rather than a string type.
@bboe
Add and use changeState and clearDisplay functions
af94668
@bboe
Refactor setPen and clean up some associated redundancies
bddb7fa 
Increase `SERVO_DELAY` to ensure points can be plotted
@bboe bboe force-pushed the label_maker_standard_improvements branch from dcb41b5 to 37ac6a5 Compare December 9, 2024 06:25
bboe added 17 commits December 8, 2024 23:24
@bboe
Rename releaseMotors to resetMotors and improve y-axis reset logic
4a2dd8f
@bboe
Modify plotCharacter to return whitespace amount and clean up
ea9fbc3
@bboe
Remove special case of using 222 for plotting a point
a1ad03c 
Instead, we can simply replace the `222` with 100 more than the previous point
@bboe
Simplify vector coordinate extraction logic in plotCharacter
b4fa63e
@bboe
Replace 200 with constant VECTOR_END
43a9ca9
@bboe
Organize operations in setup
6faee14
@bboe
Replace cursorIndex variable with confirmAction boolean
fd71016
@bboe
Fix bug where current character replaces previous character on backspace
21d8d5a 
The updated behavior moves the cursor back while keeping the selected character
at that position. This behavior seems more natural and is more friendly to
accidentally advancing the cursor forward and returning back to editing the
intended character.
@bboe
Fix bug where space characters are added before the printConfirmation
070c20f
@bboe
Use lcd.blink on the MainMenu
4e1de60
@bboe
Use lcd.blink in the Edit state
aaf23fa 
This change enables us to do away with the special handling of `_` as a space
character.
@bboe
Use lcd.blink to handle printConfirmation
bfac03d
@bboe
Clean up printing mode and highlight character being printed
230f930
@bboe
Prevent input overflow
a5a2606 
Two things are done to accomplish this:

1) Don't allow the cursor to advance beyond the 16th space

2) Return the cursor to the last added character after a "no" confirmation
   rather than to the position to the right of the last added character
@bboe
Simplify variable-width character support
04a6c97
@bboe
Use F macro for string literals
bfc532c
@bboe
Store vectors in PROGMEM
bc06d80
@bboe
Extract loop states into functions and add JoystickState struct
b3854d7 
Additionally, rename and sort states for improved consistency.
@bboe bboe force-pushed the label_maker_standard_improvements branch from 37ac6a5 to b3854d7 Compare December 9, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bboe