Improve error handling

bburky · Nov 3, 2021 · 7722013 · 7722013
1 parent 2d6308c
commit 7722013
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 16 deletions.
diff --git a/Playlist.cs b/Playlist.cs
@@ -95,22 +95,30 @@ private void UpdatePlaylistFile()
 
         public override void OnApplicationStarted(OnApplicationStartedEventArgs args)
         {
-            // Initialization is done inside OnApplicationStarted, otherwise
-            // loadPlaylistFile runs too early in Playnite's startup and
-            // cannot call PlayniteApi.Database.Games.Get()
-
-            PlaylistGames = new ObservableCollection<Game>(LoadPlaylistFile());
-            PlaylistGames.CollectionChanged += (sender, changedArgs) =>
-            {
-                UpdatePlaylistFile();
-            };
-            PlayniteApi.Database.Games.ItemCollectionChanged += (sender, changedArgs) =>
+            try
             {
-                foreach (Game game in changedArgs.RemovedItems)
+                // Initialization is done inside OnApplicationStarted, otherwise
+                // loadPlaylistFile runs too early in Playnite's startup and
+                // cannot call PlayniteApi.Database.Games.Get()
+
+                PlaylistGames = new ObservableCollection<Game>(LoadPlaylistFile());
+                PlaylistGames.CollectionChanged += (sender, changedArgs) =>
                 {
-                    PlaylistGames.Remove(game);
-                }
-            };
+                    UpdatePlaylistFile();
+                };
+                PlayniteApi.Database.Games.ItemCollectionChanged += (sender, changedArgs) =>
+                {
+                    foreach (Game game in changedArgs.RemovedItems)
+                    {
+                        PlaylistGames.Remove(game);
+                    }
+                };
+            }
+            catch (Exception e)
+            {
+                logger.Error(e, "Error loading PlaylistGames in OnApplicationStarted");
+                PlayniteApi.Notifications.Add($"{Id}-OnApplicationStarted", $"Playlist extension could not load file: {e.Message}", NotificationType.Error);
+            }
         }
     }
 }
diff --git a/PlaylistViewModel.cs b/PlaylistViewModel.cs
@@ -1,5 +1,6 @@
 using Playnite.SDK;
 using Playnite.SDK.Models;
+using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Linq;
@@ -49,8 +50,8 @@ public IEnumerable<KeyValuePair<CompletionStatus, RelayCommand<IEnumerable<objec
 
         public PlaylistViewModel(ObservableCollection<Game> playlistGames, IPlayniteAPI playniteApi)
         {
-            PlaylistGames = playlistGames;
-            this.playniteApi = playniteApi;
+            PlaylistGames = playlistGames ?? throw new ArgumentNullException(nameof(playlistGames));
+            this.playniteApi = playniteApi ?? throw new ArgumentNullException(nameof(playniteApi));
 
             NavigateBackCommand = new RelayCommand<object>((a) =>
             {