Skip to content

feat: add support for nesting vue flows #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

simonmysun
Copy link

@simonmysun simonmysun commented Jul 5, 2025

🚀 What's changed?

This draft pull request introduces support for nesting vue-flow components. Different from what's demonstrated in the nesting nodes example, this allows vue-flow instances to be nested.

  • Added new routes /nesting-flows and /recursive-nesting-flows in examples/vite/router.ts to demonstrate nested flow components.
  • Introduced a new ancestorZoom property in FlowProps to track and manage zoom levels inherited from ancester vue-flow instances.
  • Corrected coordinates calculations with ancestorZoom

图片
图片

🐛 Fixes

Bug fixed $\leqq$ 0

🪴 To-Dos

  • find a workaround for nopan class
    • Currently I removed the nopan class from nodes. This should be avoided otherwise it is a breaking change.
  • fix panBy and autopan functionalities
    • Be careful when enabling autopan, it may stuck the browser.
  • fix wheel zoom functionality
  • add example of recursive nesting flows
  • add tests
  • investigate possible vite routing issues with nested flows
    • recursive-nesting-flows example does not load when switching routes, it only works when reloading the page.
    • nesting-flows example cannot update automatically when file changes.
  • fix fitView functionality
    • Some vue issue or browser issue might be related because I have observed different behaviors in different browsers.
  • performance issues
  • connection offset when starting a connection
  • zoom behavior when max / min zoom reached
  • panning and zooming on minmap
  • possiblely add changeset

Copy link

codesandbox bot commented Jul 5, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Jul 5, 2025

⚠️ No Changeset found

Latest commit: 594617b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 5, 2025

@simonmysun is attempting to deploy a commit to the Burak Cakmakoglu's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant