Skip to content

refactor(ci): drop bcgov/action-get-pr from the .deployer.yml reusable workflow #53

Closed

Description

@DerekRoberts

Problem

The .Helm Deployer reusable workflow still uses the pre-consolidation bcgov/action-get-pr@28b0adf… # v0.3.1 to work out the default tag (the PR number) when tag is empty. bcgov/actions deprecated get-pr in favour of image-tracker (bcgov/actions#200), but image-tracker isn't a drop-in replacement here. It only returns a PR number while resolving package images.

Affected

  • .github/workflows/.deployer.yml (~line 98)

Found while removing old-repo dependencies in #48, which leaves this one in place.

Done when

  • .deployer.yml no longer depends on bcgov/action-get-pr. For example, use github.event.number on pull_request events and require tag otherwise, or resolve images with bcgov/actions/image-tracker and use its pr output.
  • The behaviour for merge/push callers is documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions