Repository navigation
ci: add PR Results gate to pr-open.yml - #125
Merged
Merged
Conversation
DerekRoberts
marked this pull request as ready for review
October 16, 2026 04:55
Copilot stopped reviewing on behalf of
DerekRoberts due to an error
October 16, 2026 04:55
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
0 open findings
What changed in this PR
Adds a single “merge gate” job to aggregate and report the overall workflow result for PRs, ensuring the workflow reports a unified status even when some jobs are skipped due to path or repo filters.
Changes:
- Introduces a
resultsjob that always runs and evaluates the outcomes of dependent jobs. - Uses
bcgov/actions/workflow-resultsto fail the workflow if any needed job failed or was cancelled.
| File | Description |
|---|---|
| .github/workflows/pr-open.yml | Adds an always-run results job to aggregate job outcomes into a single PR status. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a single
PR Resultsmerge gate topr-open.ymlusingbcgov/actions/workflow-results, pinned to the v0.9.0 release commit (79aefe3, the latest release). No other pins changed, no jobs renamed, notitle:, no version changes.Check to require on
main:PR Results(frompr-open.yml). Nothing else is needed for this workflow.Structure
PR Resultsneeds every job inpr-open.yml: Actionlint, Path filters, Test Deployer, Test Crunchy, Route TLS path filter, Test Route TLS, Test Route TLS logs, Fork Token Degradation Matrix and Test Image Import. It runs withif: always()andneeds: ${{ toJson(needs) }}, so it reports on every PR and push, and it fails if any upstream job fails or is cancelled.pg-upgrade.yml,oc-runner-commands.ymlandcert-expiry-tests.yml. A job can onlyneedjobs in its own workflow, so this gate does not cover them. Requiring their job checks directly is not recommended.cert-expiry-tests.ymlstill uses a top-levelpathsfilter, so its checks never appear on most PRs and would block them. PG Upgrade's container names change with the versions matrix. A clean follow-up is a results job in each of those files with a distinct name (for examplePG Upgrade Results). Another option is moving them into reusable workflows called frompr-open.yml, soPR Resultscovers everything. Until then they stay advisory.probe-runner-*.ymlonly run on PRs that edit their own file, andpr-close.ymlruns on close. Neither is gated.Jobs that could pass by skipping (workflow-results treats skipped as passing)
!cancelled()and treats skipped upstream jobs as nothing to scan.