Repository navigation
ci: add per-workflow results gates - #126
Merged
Merged
Conversation
Restores the push-range fix that missed the #123 squash merge.
PG Upgrade Results, oc-runner Results and Cert Expiry Results report on every PR. cert-expiry-tests.yml swaps its top-level paths filter for a job-level diff-triggers gate.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The gates cover their upstream jobs, test filtering preserves intended coverage, and no blocking issues were identified.
0 open findings
What changed in this PR
Adds per-workflow result gates so required checks report even when unrelated tests are skipped.
Changes:
- Adds result gates for PG Upgrade, oc-runner, and Cert Expiry.
- Replaces Cert Expiry’s workflow-level path filters with job-level gating.
- Updates diff comparisons to cover entire multi-commit pushes.
| File | Description |
|---|---|
.github/workflows/pr-open.yml |
Updates both filters to compare the full push range. |
.github/workflows/pg-upgrade.yml |
Adds a results gate and full push-range comparison. |
.github/workflows/oc-runner-commands.yml |
Adds a results gate and full push-range comparison. |
.github/workflows/cert-expiry-tests.yml |
Adds job-level path filtering and an always-reporting results gate. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
workflow-resultsgate to each PR workflow thatPR Resultscan't cover. All three are pinned to v0.9.0 (79aefe3a7abb2d0d00b1b3ea4cfbf12727a10638), useneeds: ${{ toJson(needs) }}andif: always(), and set notitle:. No jobs are renamed and there are no version changes.Checks to require on
main:PR Results(pr-open.yml)PG Upgrade Results(pg-upgrade.yml)oc-runner Results(oc-runner-commands.yml)Cert Expiry Results(cert-expiry-tests.yml)Changes
PG Upgrade Results, which needschanges,versions,unitandcontainers.oc-runner Results, which needschanges,commandsandunreachable-api.pathsfilter, so the workflow always runs. A newCert Expiry (changes)diff-triggers gate follows ci: narrow workflow triggers and skip Markdown-only changes #123's pattern: PR merge base,github.event.beforeon pushes, triggerscert-expiry/,.github/tests/cert-expiry/and the workflow itself, with*.mdexcluded. Both test jobs are gated on it, andCert Expiry Resultsneeds all three jobs.reffalls back togithub.event.beforeon pushes, so a multi-commit push is compared as a whole. Copilot raised this on ci: narrow workflow triggers and skip Markdown-only changes #123, and it was fixed there in ddb134f, but that commit was pushed after ci: narrow workflow triggers and skip Markdown-only changes #123 squash-merged and never reached main. This PR applies it to pg-upgrade.yml, oc-runner-commands.yml and both filters in pr-open.yml.Skipped jobs count as passing. If a path filter is too narrow, real changes can skip their tests and these gates will still go green. Keep the triggers in step with each job's dependencies.
probe-runner-*.yml(runs only when its own file changes) andpr-close.ymlstay ungated and should not be required.