Repository navigation
chore(ci): enforce actionlint in PR pipeline - #33
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Optional S3 deployments now fail, credentials may be logged, and CI does not check composite-action scripts.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds CI linting and hardens shell scripts against unsafe GitHub Actions context interpolation.
Changes:
- Adds an actionlint CI job.
- Routes workflow/action inputs through environment variables.
- Fixes deployment output references and shell redirections.
File summaries
| File | Description |
|---|---|
route-tls/action.yml |
Safely passes the action path. |
oc-runner/action.yml |
Moves inputs into environment variables. |
deployer/action.yml |
Hardens deployment scripts. |
crunchy/action.yml |
Hardens inputs and revises S3 handling. |
cleanup-pr/action.yml |
Secures cleanup command inputs. |
.github/workflows/pr-open.yml |
Adds actionlint and formats environment output. |
.github/workflows/.pr-close.yml |
Removes inline interpolation from cleanup commands. |
.github/workflows/.deployer.yml |
Hardens variables and fixes the deployment step ID. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
Summary
actionlintin.github/workflows/pr-open.ymlvia the official Docker containerrhysd/actionlint:lateston pull requests and pushes tomain.route-tls,cleanup-pr,oc-runner,deployer,crunchy) and workflow files (.deployer.yml,.pr-close.yml,pr-open.yml) to ensure all${{ github.* }}and${{ inputs.* }}expressions insiderun:and command script blocks pass through stepenv:variables rather than inline string interpolation.steps.deploystep reference in.deployer.ymland formatted redirection blocks to resolve shellcheck SC2129 style notices.