Repository navigation
fix(crunchy): use the action's own chart instead of action-crunchy@main - #56
Closed
DerekRoberts wants to merge 2 commits into
Closed
DerekRoberts wants to merge 2 commits into
DerekRoberts wants to merge 2 commits into
Conversation
DerekRoberts
requested review from
cberg-aot
and
a balanced review from Copilot
September 27, 2026 20:32
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Temporary files need cleanup, and the linked issue’s remaining legacy dependencies are unresolved.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Updates Crunchy deployments to use the action’s bundled Helm chart by default.
Changes:
- Makes external chart checkout optional.
- Copies the bundled chart into a temporary deployment directory.
- Documents the revised chart inputs.
| File | Description |
|---|---|
crunchy/action.yml |
Selects and stages the bundled chart. |
crunchy/README.md |
Updates chart input documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crunchychecked outbcgov/action-crunchy@mainon every run and deployed that repo's chart, so the chart shipped with this action was never used and deploys tracked an unpinned external branch.repositorynow defaults to''; the checkout only runs when a chart repository is set explicitly (repository/ref/directorykeep working as before for that case)crunchy/charts/crunchyis copied to a temp dir and deployed (copied becausedeploy_db.sheditsChart.yaml, writes values and packages in place)No change to what gets deployed today:
action-crunchy@main'scharts/crunchyandscripts/deploy_db.share identical to the copies here.Part of #52: covers the chart item only. The
action-diff-triggersandaction-oc-runnerreferences are left for a follow-up (oc-runner is still changing in #48).