refactor: bring in new onboarding mechanics #2406

jleach · 2025-03-13T17:57:34Z

This PR brings in the changes from openwallet-foundation/bifold-wallet#1464 as well as:

Renames "AppState" in App.tsx to be more descriptive to what it actually does;
Integrates the new on boarding mechanics from PR 1464
Integrates the new update check mechanics from PR 1466
Excludes a working directory from git.
Moves the app help URL to constants with some other URLs.

Signed-off-by: Jason C. Leach <[email protected]>

app/src/onboarding.ts

bryce-mcmath · 2025-03-26T01:26:53Z

app/src/screens/Splash.tsx

-        if (
-          !mounted ||
-          initializing.current ||
-          !store.authentication.didAuthenticate ||


I think we still need just the !store.authentication.didAuthenticate check here as per this PR:
openwallet-foundation/bifold-wallet#1477

Just curious, is there a reason you moved the early return after the checkForUpdates() call? Might cause it to be called many times

I'm on the fence with this one. You can't get to the Splash screen unless you complete either the PIN Create or PIN Enter which both complete authentication. So if you're seeing Splash you must have completed authentication. So, on 2nd though - this change may not have been needed.

EDIT: It was needed in the previous incarnation because Splash would have routed to the PIN mechanics. This is no longer the case.

Thoughts?

I moved it after because it should be cached at this point and didAuthenticate is only required for the agent. I think it would be better to move the initialized check up if we don't want to repeat this fn call. Thoughts?

bryce-mcmath · 2025-03-26T01:28:48Z

app/src/screens/Splash.tsx

        if (!agent) {
-          initializing.current = false


I think we still need these two, no? Or else if it fails initialization the first, the retry button won't work

bryce-mcmath · 2025-03-26T01:29:50Z

app/src/screens/Splash.tsx

        navigation.dispatch(
          CommonActions.reset({
            index: 0,
            routes: [{ name: Stacks.TabStack }],
          })
        )
      } catch (e: unknown) {
-        initializing.current = false


bryce-mcmath

One small nit about placement of checkForUpdates() call

bryce-mcmath · 2025-03-26T17:42:45Z

app/src/screens/Splash.tsx

@@ -24,77 +22,11 @@ import TipCarousel from '../components/TipCarousel'
 import useInitializeBCAgent from '../hooks/initialize-agent'
 import { BCState } from '../store'

-import { TermsVersion } from './Terms'
-
-const OnboardingVersion = 2


So OnboardingVersion just isn't needed anymore? That's awesome

No, I can't think of any reason to keep it. We do use TermsVersion.

bryce-mcmath · 2025-03-26T17:43:00Z

app/src/screens/Splash.tsx

-        if (
-          !mounted ||
-          initializing.current ||
-          !store.authentication.didAuthenticate ||


Just curious, is there a reason you moved the early return after the checkForUpdates() call? Might cause it to be called many times

bryce-mcmath · 2025-03-26T18:53:36Z

release-fb.xcconfig

accidentally committed?

Signed-off-by: Jason C. Leach <[email protected]>

Signed-off-by: al-rosenthal <[email protected]>

sonarqubecloud · 2025-03-26T22:45:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jleach changed the title ~~Refactor/update onboarding~~ refactor: bring in new onboarding mechanics Mar 13, 2025

jleach marked this pull request as draft March 13, 2025 21:23

jleach added the do not merge This PR is on hold. label Mar 13, 2025

jleach added 11 commits March 25, 2025 12:20

feat: check for updates

f007b48

Signed-off-by: Jason C. Leach <[email protected]>

refactor: update for new onboarding

0a93520

Signed-off-by: Jason C. Leach <[email protected]>

refactor: cleanup

f19a223

Signed-off-by: Jason C. Leach <[email protected]>

refactor: cleanup

6b33eee

Signed-off-by: Jason C. Leach <[email protected]>

refactor: reverse changes

8ce571b

Signed-off-by: Jason C. Leach <[email protected]>

refactor: reverse changes

59a2bed

Signed-off-by: Jason C. Leach <[email protected]>

refactor: cleanup

2e56446

Signed-off-by: Jason C. Leach <[email protected]>

refactor: cleanup

45d334f

Signed-off-by: Jason C. Leach <[email protected]>

fix: splash

8285383

Signed-off-by: Jason C. Leach <[email protected]>

feat: work on version check

07a3efd

Signed-off-by: Jason C. Leach <[email protected]>

feat: work on version check

591ff72

Signed-off-by: Jason C. Leach <[email protected]>

jleach force-pushed the refactor/update-onboarding branch from 1bd72d1 to 591ff72 Compare March 25, 2025 21:48

jleach added 13 commits March 25, 2025 14:50

chore: code cleanup

b71a8b2

Signed-off-by: Jason C. Leach <[email protected]>

chore: code cleanup

6ef92bc

Signed-off-by: Jason C. Leach <[email protected]>

chore: code cleanup

b858489

Signed-off-by: Jason C. Leach <[email protected]>

chore: code cleanup

a6f50b2

Signed-off-by: Jason C. Leach <[email protected]>

fix: yarn lock

482aed5

Signed-off-by: Jason C. Leach <[email protected]>

fix: codeql

fa7a633

Signed-off-by: Jason C. Leach <[email protected]>

fix: codeql

5ba015f

Signed-off-by: Jason C. Leach <[email protected]>

fix: codeql

bb86476

Signed-off-by: Jason C. Leach <[email protected]>

fix: codeql

2056b2e

Signed-off-by: Jason C. Leach <[email protected]>

fix: codeql

3e0a5b9

Signed-off-by: Jason C. Leach <[email protected]>

fix: codeql

4c63ffb

Signed-off-by: Jason C. Leach <[email protected]>

fix: update dependencies

0e43169

Signed-off-by: Jason C. Leach <[email protected]>

fix: update dependencies

c79a571

Signed-off-by: Jason C. Leach <[email protected]>

jleach marked this pull request as ready for review March 26, 2025 00:19

jleach requested a review from bryce-mcmath March 26, 2025 00:19

jleach requested a review from al-rosenthal March 26, 2025 00:19

bryce-mcmath requested changes Mar 26, 2025

View reviewed changes

jleach requested a review from bryce-mcmath March 26, 2025 17:48

bryce-mcmath reviewed Mar 26, 2025

View reviewed changes

release-fb.xcconfig Outdated

Copy link

Contributor

bryce-mcmath Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidentally committed?

jleach reacted with thumbs up emoji

fix: pr feedback

84aa285

Signed-off-by: Jason C. Leach <[email protected]>

jleach force-pushed the refactor/update-onboarding branch from ddf41df to 84aa285 Compare March 26, 2025 18:59

jleach removed the do not merge This PR is on hold. label Mar 26, 2025

jleach enabled auto-merge (squash) March 26, 2025 19:08

jleach requested a review from bryce-mcmath March 26, 2025 20:36

al-rosenthal added 2 commits March 26, 2025 15:13

fix: updated packages and agent initialization

3806c93

Signed-off-by: al-rosenthal <[email protected]>

fix: updated theme

85a7e46

Signed-off-by: al-rosenthal <[email protected]>

bryce-mcmath approved these changes Mar 26, 2025

View reviewed changes

al-rosenthal mentioned this pull request Mar 26, 2025

refactor: refactored agent initialization #2419

Closed

jleach merged commit 664eb75 into main Mar 26, 2025
26 checks passed

jleach deleted the refactor/update-onboarding branch March 26, 2025 23:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: bring in new onboarding mechanics #2406

refactor: bring in new onboarding mechanics #2406

Uh oh!

jleach commented Mar 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

bryce-mcmath Mar 26, 2025

Uh oh!

jleach Mar 26, 2025

Uh oh!

bryce-mcmath Mar 26, 2025

Uh oh!

jleach Mar 26, 2025 •

edited

Loading

Uh oh!

bryce-mcmath Mar 26, 2025

Uh oh!

jleach Mar 26, 2025

Uh oh!

bryce-mcmath Mar 26, 2025

Uh oh!

jleach Mar 26, 2025

Uh oh!

bryce-mcmath left a comment

Uh oh!

bryce-mcmath Mar 26, 2025

Uh oh!

jleach Mar 26, 2025

Uh oh!

bryce-mcmath Mar 26, 2025

Uh oh!

bryce-mcmath Mar 26, 2025

Uh oh!

sonarqubecloud bot commented Mar 26, 2025

Uh oh!

Uh oh!

Uh oh!

refactor: bring in new onboarding mechanics #2406

refactor: bring in new onboarding mechanics #2406

Uh oh!

Conversation

jleach commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jleach Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bryce-mcmath left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 26, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

jleach commented Mar 13, 2025 •

edited

Loading

jleach Mar 26, 2025 •

edited

Loading