Repository navigation
chore(ci): migrate workflows to consolidated action suites - #490
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The reusable deploy workflow and PR-close workflow contain inconsistent secret/variable context names that will likely evaluate to empty at runtime and break authentication to OpenShift/Crunchy actions.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR migrates several GitHub Actions workflows to the consolidated bcgov/actions@v0.7.0 and bcgov/actions-openshift@v0.3.0 suites, replacing older standalone actions and helper reusable workflows while keeping action references pinned to full commit SHAs.
Changes:
- Replaced legacy
bcgov/action-*actions withbcgov/actions/*andbcgov/actions-openshift/*equivalents across PR and deploy workflows. - Introduced
bcgov/actions/workflow-resultsfor consolidated “gate”/results reporting in PR open/validate and analysis workflows. - Updated the PR validate workflow to run as a standard job with
bcgov/actions/pr-validatesteps (instead of a helper reusable workflow).
File summaries
| File | Description |
|---|---|
| .github/workflows/pr-validate.yml | Replaces helper reusable workflow with bcgov/actions/pr-validate and adds consolidated results reporting. |
| .github/workflows/pr-open.yml | Switches image build action to bcgov/actions/builder and adds consolidated results reporting. |
| .github/workflows/pr-close.yml | Migrates PR-close reusable workflow and Crunchy cleanup action to bcgov/actions-openshift. |
| .github/workflows/analysis.yml | Uses consolidated results reporting and improves shell variable quoting for $GITHUB_PATH. |
| .github/workflows/.deploy.yml | Migrates Crunchy + oc-runner steps to bcgov/actions-openshift actions. |
Review details
Suppressed comments (1)
.github/workflows/pr-close.yml:37
cleanup_dbis using different variable/secret names than the rest of the workflows in this repo (and than this file’scleanupjob).vars.oc_namespace/secrets.oc_tokenare likely undefined, which would cause the Crunchy step to fail to authenticate. Align these to the existingOC_NAMESPACE/OC_TOKENnames used elsewhere.
oc_namespace: ${{ vars.oc_namespace }}
oc_token: ${{ secrets.oc_token }}
oc_server: ${{ vars.oc_server }}
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate CI/CD workflows to
bcgov/actions@v0.7.0andbcgov/actions-openshift@v0.3.0, pinned to full commit SHAs per portfolio standards:.deploy.yml: Replace standalonebcgov/action-crunchyandbcgov/action-oc-runnerwithbcgov/actions-openshift/crunchyandbcgov/actions-openshift/oc-runner.pr-open.yml: Replacebcgov/action-builder-ghcrwithbcgov/actions/builder, and adoptbcgov/actions/workflow-resultsfor consolidated gate reporting.pr-close.yml: Replace helper workflowbcgov/quickstart-openshift-helpers/.github/workflows/.pr-close.ymlandbcgov/action-crunchywithbcgov/actions-openshift/.github/workflows/.pr-close.ymlandbcgov/actions-openshift/crunchy.pr-validate.yml: Replace helper workflow withbcgov/actions/pr-validateandbcgov/actions/workflow-results.analysis.yml: Adoptbcgov/actions/workflow-resultsand quote shell variables.Java
Py