Skip to content

Conversation

@sshugsc
Copy link
Contributor

@sshugsc sshugsc commented Jan 8, 2026

KBDEV-1404:

  • exclude displayName when patch the variant (displayName will be generated by API if it is not provided)

@sshugsc sshugsc self-assigned this Jan 8, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.69%. Comparing base (cbe521d) to head (1b2378a).

Files with missing lines Patch % Lines
src/components/VariantForm/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #104      +/-   ##
===========================================
- Coverage    56.70%   56.69%   -0.02%     
===========================================
  Files          102      102              
  Lines         3890     3891       +1     
  Branches      1316     1316              
===========================================
  Hits          2206     2206              
- Misses        1672     1673       +1     
  Partials        12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sshugsc sshugsc marked this pull request as ready for review January 8, 2026 19:17
@mathieulemieux
Copy link
Member

mathieulemieux commented Jan 12, 2026

Tested on both CategoryVariant and PositionalVariant and displayName get regenerated as expected.
Existing tests are passing.

@elewis2, 2 comments:

  • Refreshing the page is needed in order to see the changes. Discussed at last Sprint meeting; don't know if supposed to happen in this PR, in another one, or it's a won't do.
  • Had to use Node v20 to align with current lockFileVersion 3 when installing dependencies, but GH checks still using v16. Discussed ~2y ago here: Chore/kbdev 1206 update pori imports #78 (review)

@sshugsc sshugsc marked this pull request as draft January 13, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants