Skip to content

bugfix/DEVSU-2796-variant-appearing-twice-in-VUS-table #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sshugsc wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

bugfix/DEVSU-2796-variant-appearing-twice-in-VUS-table #472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6924e16
avoid duplicate push to unknownSignificanceFromGeneProperty
sshugsc Dec 5, 2025
4bce94e
update id to ident
sshugsc Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/routes/report/variants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,14 @@ const getRapidReportVariants = async (tableName, variantType, reportId, rapidTab

// add variants back to unknownSig list, that are tagged for this table based on gene properties alone
// so that they can be filtered out of results if they are in TA or CR
unknownSignificanceResults.push(...unknownSignificanceFromGeneProperty);
const existingVariants = new Set(unknownSignificanceResults.map((variant) => {return variant.ident;}));

unknownSignificanceFromGeneProperty.forEach((variant) => {
if (!existingVariants.has(variant.ident)) {
unknownSignificanceResults.push(variant);
existingVariants.add(variant.ident);
}
});

// remove variants already included in a different section
for (const row of unknownSignificanceResults) {
Expand Down
Loading