Fix compatibility for PHP 8☠ #6260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK ci3 must remain compatible with php 5.6 (maybe 5.4?) |
|
@tenzap Good call. Adding symfony/polyfill could be an option; it'd handle this and enable the use of more recent PHP functions in other parts of the system. Edit: Alternatively, spl_object_hash() is PHP 5.2+, and would probably be the best option. |
|
Hi there. If you could check the fix provided in #6264, it would be much appreciated. If you find anything faulty, please leave a comment there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.