Add node export/import workflow using shared transfer utilities #185
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| state.docVersions[documentId] = docVersions; | ||
|
|
||
| const latestVersion = docVersions[docVersions.length - 1] ?? null; | ||
|
|
||
| baseNode.document = { |
There was a problem hiding this comment.
When importing nodes that contain versions, docVersions are appended in the same order they arrive. The export code populates versions from getVersionsForNode, which returns entries sorted newest-first. Because latestVersion is derived from docVersions[docVersions.length - 1], the imported document’s current_version_id and content end up pointing to the oldest revision instead of the most recent one. Users who export with “Include document history” will see stale content after importing. Reverse the array or pick the first entry when deciding which version is current.
Useful? React with 👍 / 👎.
| let latestVersionId: number | null = null; | ||
|
|
||
| for (const entry of normalizedVersions) { | ||
| const sha = crypto.createHash('sha256').update(entry.content).digest('hex'); | ||
| const existingContent = db |
There was a problem hiding this comment.
The same ordering issue occurs in the Electron-backed import: the loop iterates the serialized node.versions in the order provided and assigns latestVersionId on every iteration. Because exported histories are newest-first, the value left in latestVersionId after the loop is the oldest revision, so documents.current_version_id will reference stale content even though newer versions were inserted. Imports that include histories will therefore load the wrong document content. Choose the first entry or iterate oldest-to-newest before setting the current version.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ffafe41c808332942f1cd9a6fbd121