Skip to content

Specialise validation for metric and event_name - #125

Merged
josevalim merged 1 commit into
beam-telemetry:mainfrom
cpiemontese:main
Feb 6, 2026
Merged

josevalim merged 1 commit into
beam-telemetry:mainfrom
cpiemontese:main

Conversation

@cpiemontese

Copy link
Copy Markdown
Contributor

Trying to address #124

I was unsure how to address this and I opted for "specialising" the error message/validation base on what's being validated

This will "break" error messages in a sense, but it hopefully makes clearer what's not working (metric or event_name) and why

Happy to change the approach if it doesn't make sense

@codecov-commenter

codecov-commenter commented Feb 6, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.33%. Comparing base (ab86164) to head (4d583eb).
⚠️ Report is 11 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #125      +/-   ##
===========================================
- Coverage   100.00%   99.33%   -0.67%     
===========================================
  Files            2        2              
  Lines          145      151       +6     
===========================================
+ Hits           145      150       +5     
- Misses           0        1       +1     
Files with missing lines Coverage Δ
lib/telemetry_metrics.ex 98.97% <100.00%> (-1.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232ebf6...4d583eb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josevalim
josevalim merged commit cd567c2 into beam-telemetry:main Feb 6, 2026
2 checks passed
@josevalim

Copy link
Copy Markdown
Contributor

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants