Skip to content

Conversation

@zkornbluth
Copy link
Contributor

Team colors weren't available from Jim Nielsen's site, so I pulled them from other sources (Mammoth directly from their logo on NHL.com, Kraken from https://teamcolorcodes.com/seattle-kraken-colors/).

Also the Oakland Athletics have dropped the 'Oakland' from their name, so I accounted for that. That will need to change again in a few years when the make the move to Las Vegas.

Fixes #33.

Team colors weren't available from Jim Nielsen's site, so pulled them from other sources. Also the Oakland Athletics have dropped the 'Oakland'.
Copy link
Collaborator

@gjm112 gjm112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Couple minor reworks to match what gets pulled. Should preserve all the conference changes from beanumber#34.
@zkornbluth
Copy link
Contributor Author

Doesn't appear that I can handle the merge conflict for teamcolors.rda

@gjm112
Copy link
Collaborator

gjm112 commented Sep 22, 2025 via email

@gjm112 gjm112 merged commit dbadf85 into beanumber:master Sep 22, 2025
@gjm112
Copy link
Collaborator

gjm112 commented Sep 22, 2025

I believe this has been fixed. The kraken are added, coyotes removed, and Oakland Athletics are not just athletics.

@zkornbluth zkornbluth deleted the issue-33 branch September 22, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NHL Logos

2 participants