Skip to content

Render job stacktraces not only in permalink view #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laurens wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Render job stacktraces not only in permalink view #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/server/views/dashboard/jobDetails.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ async function handler(req, res) {
job.retryButtonText = jobState === 'failed' ? 'Retry' : 'Trigger';
job.showPromoteButton = !queue.IS_BEE && jobState === 'delayed';
job.showDeleteRepeatableButton = queue.IS_BULL && job.opts.repeat;
const stacktraces = queue.IS_BEE ? job.options.stacktraces : job.stacktrace;
job.stacktraces = queue.IS_BEE ? job.options.stacktraces : [job.stacktrace];

if (!queue.IS_BEE) {
const logs = await queue.getJobLogs(job.id);
Expand Down Expand Up @@ -110,7 +110,6 @@ async function handler(req, res) {
queueHost,
jobState,
job,
stacktraces,
hasFlows: Flows.hasFlows(),
});
}
Expand Down
3 changes: 3 additions & 0 deletions src/server/views/dashboard/queueJobsByState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ async function _html(req, res) {
jobs[i].showPromoteButton = !queue.IS_BEE && jobState === 'delayed';
jobs[i].showDeleteRepeatableButton = !queue.IS_BEE && jobs[i].opts.repeat;
jobs[i].parent = JobHelpers.getKeyProperties(jobs[i].parentKey);
jobs[i].stacktraces = queue.IS_BEE
? jobs[i].options.stacktraces
: [jobs[i].stacktrace];
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/server/views/dashboard/templates/jobDetails.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<h2>Queue <code>{{ queueHost }}/{{ queueName }}</code></h2>

{{> dashboard/jobDetails job basePath=basePath queueName=queueName queueHost=queueHost jobState=jobState stacktraces=stacktraces view=true}}
{{> dashboard/jobDetails job basePath=basePath queueName=queueName queueHost=queueHost jobState=jobState view=true}}

{{#contentFor 'sidebar'}}
<li><a href="{{ basePath }}/">Queues Overview</a></li>
Expand All @@ -19,4 +19,4 @@ if(document.getElementById('jsoneditor')) {
window.jsonEditor = new JSONEditor(document.getElementById('jsoneditor'), { modes: ['code','tree','text'] });
window.jsonEditor.set({{json job.data true}})
}
{{/contentFor}}
{{/contentFor}}