Skip to content

fix: named serde default for supersedes_demotion #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Liorrr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: named serde default for supersedes_demotion #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/shrimpk-core/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ pub struct EchoConfig {
pub child_memory_penalty: f32,
/// Supersession demotion factor (multiplicative). 0.40 = retain 60% of score.
/// Applied as `score *= (1 - factor)^count` for each supersession edge.
#[serde(default)]
#[serde(default = "default_supersedes_demotion")]
pub supersedes_demotion: f32,
/// Custom system prompt for the consolidator LLM fact extraction.
/// Use `{max_facts}` placeholder for the max facts count.
Expand Down Expand Up @@ -431,6 +431,10 @@ fn default_recency_weight() -> f32 {
0.05
}

fn default_supersedes_demotion() -> f32 {
0.40
}

fn default_max_disk_bytes() -> u64 {
DEFAULT_MAX_DISK_BYTES
}
Expand Down
Loading