Repository navigation
Install FILE_SET CXX_MODULES too - #13
Closed
ClausKlein wants to merge 3 commits into
Closed
ClausKlein wants to merge 3 commits into
ClausKlein wants to merge 3 commits into
Conversation
ClausKlein
requested review from
JeffGarland,
ednolan,
neatudarius,
rishyak and
wusatosi
as code owners
January 16, 2026 21:17
ClausKlein
commented
Jan 18, 2026
ClausKlein
left a comment
ClausKlein
left a comment
Contributor
Author
There was a problem hiding this comment.
@ednolan Is this intended?
Comment on lines
69
to
+75
| install( | ||
| TARGETS "${target_name}" | ||
| COMPONENT "${install_component_name}" | ||
| EXPORT "${export_name}" | ||
| FILE_SET HEADERS | ||
| FILE_SET CXX_MODULES | ||
| DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${package_name}/modules |
Contributor
Author
There was a problem hiding this comment.
why is this installed() always done?
installed header, or modules without cmake config packages may NOT be useable, or?
Contributor
Author
|
This file needs completly refactored! |
steve-downey
pushed a commit
to steve-downey/infra
that referenced
this pull request
Feb 14, 2026
Add toolchain files and beman-submodule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for bemanproject/exemplar#286
I would like to use this version https://github.com/ClausKlein/execution/blob/221f2fe8baf305e2fdbe7e3b0614a900d4aeacb2/cmake/beman-install-project-targets.cmake