Display the configured percentile in the console reports - #490
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
The console formatters matched `percentiles: %{99 => value}` and
hardcoded the "99th %" column, so a `percentiles` configuration
without 99 raised a MatchError and lost all results.
Report the highest calculated percentile instead, which keeps 99 as
the default while making the column follow the configuration.
The fourth argument of format_scenario carries the percentile now, so the branches matching true could never be reached - dialyzer flagged both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
percentilesconfiguration without 99 raised aMatchErrorand lost all results, because the three console formatters matchedpercentiles: %{99 => value}and hardcoded the99th %header. The reports now use the highest calculated percentile and label the column with it, so the default stays at 99 and the column follows the configuration, as discussed in #152.Verified with a manual
percentiles: [50, 90]run that previously raised,mix format --check-formatted,mix credo, andmix test(138 doctests, 350 tests, with the single failure being the iex integration test that also fails on an unmodified checkout in this environment).Fixes #489