Skip to content

SOLVER Implement SOAP#11

Open
svaiter wants to merge 11 commits intobenchopt:mainfrom
svaiter:soap
Open

SOLVER Implement SOAP#11
svaiter wants to merge 11 commits intobenchopt:mainfrom
svaiter:soap

Conversation

@svaiter
Copy link

@svaiter svaiter commented Jan 7, 2026

This PR intends to implement the SOAP algorithm from https://arxiv.org/abs/2409.11321

It is drafted from the original soap.py implementation available at https://github.com/nikhilvyas/SOAP/blob/main/soap.py

OpenAI codex was used to start this feature using the following prompt on the repository:

Adapt original_soap.py optimizer in solvers/soap.py to conform the use of benchopt. Look at adam.py to understand how to modify the code.

Default hyperparameter (lr and weight_decay) were not working on Simulated dataset (3e-3 and 1e-2). Default parameter of Adam neither (1e-3 and 1e-4).
Current working are 1e-4 and 1e-3

TODO

  • Review carefuly the generated code.
  • Explore hyperparameters.
  • Test the DDP on a multi gpu machine

@svaiter svaiter changed the title SOLVER start working on SOAP (using codex) SOLVER Implement SOAP Jan 7, 2026
@tomMoral
Copy link
Member

tomMoral commented Jan 15, 2026

seems to be working with only a few tweaks:
image

But the performances are not super good

Copy link
Member

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a few extra clean up.
Just one comment on the parameters, it feels like there are too many.

@svaiter svaiter marked this pull request as ready for review January 15, 2026 10:54
Copy link
Member

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweaks that can be helpful

@svaiter
Copy link
Author

svaiter commented Jan 15, 2026

@tomMoral Shall we merge it like that, or do additional hyperparameter experiences?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants