Replace traverse with neotraverse #10
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently in this repo, we've seen some efforts (bendrucker#7, bendrucker#8) to cope with (according to some, including myself-) hijacked traverse package. This PR replaces traverse with neotraverse, a fork and TypeScript rewrite of traverse with 0 dependencies and lots of improvements.
Jayllyz
approved these changes
Aug 3, 2024
|
Does this actually fix a problem? I'm declaring this package frozen, unless there is an urgent performance/security issue with the pinned version of traverse I'm not keen to participate in continued bikeshedding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently in this repo, we've seen some efforts (#7, #8) to cope with (according to some, including myself-) hijacked traverse package.
This PR replaces traverse with neotraverse, a fork and TypeScript rewrite of traverse with 0 dependencies and lots of improvements.