Crop in pixel space instead of point space - #54
Merged
Conversation
`calculateCropRect` measured against `PlatformImage.size` while `CGImage.cropping(to:)` cuts in pixels. The two differ whenever an image carries DPI metadata other than 72 on macOS, or a `scale` other than 1 on iOS, so the result came out too small and offset towards the top left. The circular crop renders in point space and was never affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calculateCropRectmeasured againstPlatformImage.sizewhileCGImage.cropping(to:)cuts in pixels. The two differ whenever an image carries DPI metadata other than 72 on macOS, or ascaleother than 1 on iOS, so the result came out too small and offset towards the top left.The circular crop renders in point space and was never affected.