Restore configured background and make progress UI configurable - #55
Merged
benedom merged 5 commits intoAug 7, 2026
Merged
Conversation
Owner
|
Hi @jacklieblich looks good! I wired the background into the demo app and added you as a contributor to the README. It this looks good to you I will merge :) |
benedom
approved these changes
Aug 7, 2026
benedom
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configuration.colors.backgroundas the background of the main crop viewshowsProgressLayerso clients can disable the progress UI when they provide their own loading feedbackprogressLayerDelayso clients can avoid flashing the progress UI for crops that finish quickly.zeroWhy
The real-toolbar refactor removed the crop view's configured background even though the public API and documentation still describe
colors.backgroundas the background of the entire cropping view. The crop content consequently becomes transparent, which can reduce contrast between the retained and discarded areas and make white toolbar controls difficult to see over a light presenting surface. The restored background is applied outside the iOS 26 scroll-edge wrapper so it also covers that wrapper's transparent toolbar spacer.The progress layer is also currently inserted for every crop. In repeated or app-owned crop sessions, fast synchronous crops can render it for only a frame, which looks like a glitch.
showsProgressLayerlets clients with their own loading state disable it, whileprogressLayerDelaylets other clients defer it; SwiftUI automatically cancels the delayed view task when cropping finishes before the threshold.Compatibility
showsProgressLayerdefaults totrueand the delay defaults to.zero, so existing clients retain the current immediate progress-layer behavior.Testing
swift test: 7 passed