Skip to content

Fix TypeScript ESM compatibility #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TypeScript ESM compatibility #647

wants to merge 1 commit into from

Conversation

benquarmby
Copy link

This PR adds missing .js extensions to imports so that ESM + TypeScript consumers don't hit these errors:

../node_modules/@wry/caches/lib/strong.d.ts(1,34): error TS2835: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './common.js'?
../node_modules/@wry/caches/lib/weak.d.ts(1,34): error TS2835: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './common.js'?

Fixes #646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@wry/caches is not compatible with moduleResolution = node16
1 participant
@benquarmby