Skip to content

Fix wrong rotations of footprints imported with easyeda2kicad #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoNil wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wrong rotations of footprints imported with easyeda2kicad #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions plugins/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,11 @@ def _get_rotation_from_db(self, footprint: str, lib_nickname: str = None) -> flo
footprint: The footprint name
lib_nickname: The library nickname, if available
'''
# LCSC/EasyEDA footprints (library nickname like "C24639") already use
# JLCPCB's expected orientation, so skip the rotation correction database.
if lib_nickname and re.match(r'^C\d+$', lib_nickname):
return 0.0

# First try with the standard approach for backward compatibility
for entry in self.__rotation_db.items():
# If the expression in the DB contains a :, search for it literally.
Expand Down Expand Up @@ -431,6 +436,10 @@ def _get_position_offset_from_db(self, footprint: str, lib_nickname: str = None)
footprint: The footprint name
lib_nickname: The library nickname, if available
'''
# LCSC/EasyEDA footprints already use JLCPCB's expected orientation/position.
if lib_nickname and re.match(r'^C\d+$', lib_nickname):
return (0.0, 0.0)

# First try with the standard approach for backward compatibility
for entry in self.__rotation_db.items():
# If the expression in the DB contains a :, search for it literally.
Expand Down