Skip to content

Fix some code styling #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some code styling #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 20 additions & 21 deletions data-structures-in-javascript/tree.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,13 @@ class Tree {
add(data, toNodeData) {
const node = new Node(data);
const parent = toNodeData ? this.findBFS(toNodeData) : null;
if(parent) {
if (parent) {
parent.children.push(node);
} else {
if(!this.root) {
this.root = node;
} else {
return 'Root node is already assigned';
if (this.root) {
throw new Error('Root node is already assigned');
}
this.root = node;
}
}

Expand All @@ -31,7 +30,7 @@ class Tree {
while(queue.length) {
const node = queue.shift();
for (let [index, child] of node.children.entries()) {
if(child.data === data) {
if (child.data === data) {
node.children.splice(index, 1);
} else {
queue.push(child);
Expand All @@ -48,19 +47,19 @@ class Tree {
const queue = [this.root];
while(queue.length) {
const node = queue.shift();
if(node.data === data) {
if (node.data === data) {
return node;
}
for(const child of node.children) {
for (const child of node.children) {
queue.push(child);
}
}
return null;
}

_preOrder(node, fn) {
if(node) {
if(fn) {
if (node) {
if (fn) {
fn(node);
}
for(const child of node.children) {
Expand All @@ -70,19 +69,19 @@ class Tree {
}

_postOrder(node, fn) {
if(node) {
for(const child of node.children) {
if (node) {
for (const child of node.children) {
this._postOrder(child, fn);
}
if(fn) {
if (fn) {
fn(node);
}
}
}

traverseDFS(fn, method) {
const current = this.root;
if(method) {
if (method) {
this[`_${method}`](current, fn);
} else {
this._preOrder(current, fn);
Expand All @@ -91,31 +90,31 @@ class Tree {

traverseBFS(fn) {
const queue = [this.root];
while(queue.length) {
while (queue.length) {
const node = queue.shift();
if(fn) {
if (fn) {
fn(node);
}
for(const child of node.children) {
for (const child of node.children) {
queue.push(child);
}
}
}

print() {
if(!this.root) {
if (!this.root) {
return console.log('No root node found');
}
const newline = new Node('|');
const queue = [this.root, newline];
let string = '';
while(queue.length) {
while (queue.length) {
const node = queue.shift();
string += `${node.data.toString()} `;
if(node === newline && queue.length) {
if (node === newline && queue.length) {
queue.push(newline);
}
for(const child of node.children) {
for (const child of node.children) {
queue.push(child);
}
}
Expand Down