Skip to content

Conversation

@H-MAli
Copy link

@H-MAli H-MAli commented Jul 27, 2025

Change Description

So, I needed to run some external application on some key connection events on OD. That's what inspired these changes I am calling event hooks. Basically, when OD connects successfully, fails to connect, or get a connection error mid-operation, user will be able to run their specified programs.

Checklist

  • Code has been tested.
    • Windows 10
    • Windows 11
    • macOS
    • Linux
  • Relevant documentation has been updated.

@ircfspace
Copy link
Collaborator

Thank you for your contribution to the development of Oblivion Desktop.
Before proceeding with a full review and potentially merging the PR, please consider the following points:

  1. The test-hook files should not be placed in the root directory of the project. It's preferable to move them into a subfolder, such as sandbox.

  2. Although the hooks are a useful feature, they are not commonly used by most users. To avoid cluttering the app's settings and to stay aligned with the current UX direction, it's recommended that access to Hooks remain available through a dialog in the settings section, and all enable/disable options be listed within that dialog. (I'll work on improving its styling later.)

  3. Some new errors appear in the logs during initial execution. These should be checked in the terminal.

@H-MAli
Copy link
Author

H-MAli commented Jul 27, 2025

Of course.
I'll look into the 3rd point you are making and get back if I find anything related.

@H-MAli
Copy link
Author

H-MAli commented Jul 27, 2025

This feature must be skipped in mobile builds I guess. Thoughts?

@ircfspace
Copy link
Collaborator

Yes. This repository is only for Windows, Linux, and macOS.

@ircfspace
Copy link
Collaborator

Are you currently working on this PR?
@H-MAli

@H-MAli
Copy link
Author

H-MAli commented Aug 9, 2025

Sorry. Been busy a bit in the past couple of days. Will look into the pending issues in the coming days. Hopefully till the end of the week.

@ircfspace
Copy link
Collaborator

@H-MAli Hello again,
The app is still under development, and this process is causing more conflicts in this PR.
Do you still intend to continue working on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants