Skip to content

Conversation

ftzi
Copy link
Contributor

@ftzi ftzi commented Aug 30, 2025

Adds a setting for the default font (so that font is not added to the classname) and for the threshold to use exact values.

Please try it out as I don't know how to test this locally (I did run pnpm dev but can I use it on Figma?).

@bernaferrari
Copy link
Owner

To test locally you need to use pnpm dev (feel free to do cd apps/plugin, then pnpm dev so it doesn't run the debug version), then go to Figma and import the manifest, it will appear as debug.

@ftzi ftzi force-pushed the add-font-and-threshold-settings branch from c54a85e to 1ef8869 Compare August 30, 2025 03:47
@ftzi
Copy link
Contributor Author

ftzi commented Aug 30, 2025

It works!!!

Both running it locally and the PR changes.

I also noticed that the output generates font-normal (fontWeight 400).

Is it wanted? I would say it could be removed as this is the default.

Or, maybe I could add a new setting for a comma separated classNames to be automatically removed.

@bernaferrari
Copy link
Owner

I don't know, I do font-normal because you never know where people are going to paste the code, but maybe we could remove too, I don't know, do you see any reasons to stay with it?

@ftzi
Copy link
Contributor Author

ftzi commented Aug 30, 2025

Hmm. Hard to say. If I were the only user I would remove it, but I don't know how people use this.

Having the "classname-blacklist" is the safest choice and would also catch other situations I / the user doesn't want it.

@bernaferrari
Copy link
Owner

maybe we can remove and if anyone complains we add again

@bernaferrari
Copy link
Owner

I'll merge very soon (I just forgot + even if I merge I need to deploy later so don't worry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants