Use docker buildx imagetools create for multi-arch manifest creation#10187
Open
DeathGun44 wants to merge 1 commit intobesu-eth:mainfrom
Open
Use docker buildx imagetools create for multi-arch manifest creation#10187DeathGun44 wants to merge 1 commit intobesu-eth:mainfrom
DeathGun44 wants to merge 1 commit intobesu-eth:mainfrom
Conversation
33e5957 to
be4a242
Compare
Signed-off-by: DeathGun44 <[email protected]>
be4a242 to
d6de0f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Docker 29 defaults to the containerd image store, which preserves BuildKit provenance
attestations on push. This turns per-arch images into OCI indices (manifest lists),
causing
docker manifest createto reject them as sources.Switch to
docker buildx imagetools createwhich handles OCI indices natively andcombines create+push into a single atomic command. Also removes the
--provenance=falseworkaround added in #9817, re-enabling SLSA provenance attestations.
Transition context: A standalone GitHub Actions workflow for multi-arch builds is being introduced in parallel (see #10203 ). This PR patches the Gradle tasks so they remain functional on Docker 29 during the transition period, honoring the co-existence strategy. Once the GHA workflow is proven stable, the Gradle Docker tasks will be deprecated in a follow-up PR.
Changes:
--provenance=falsefromdistDockermanifestDockerCreate→manifestDockerPush→manifestDocker) with a singlemanifestDockertask usingdocker buildx imagetools createmanifestDockerReleaseCreate→manifestDockerReleasePush→manifestDockerRelease) with a singlemanifestDockerReleasetaskNo CI workflow YAML changes needed — task names called by
develop.yml,draft-release.yml, anddocker-promote.ymlare preserved.Fixed Issue(s)
fixes #9818
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR — no doc changes needed, internal build tooling onlyLocally, you can run these tests to catch failures early:
./gradlew spotlessApply