Harden RocksDB retry detection and error accounting#10214
Open
Solanasol233 wants to merge 1 commit intobesu-eth:mainfrom
Open
Harden RocksDB retry detection and error accounting#10214Solanasol233 wants to merge 1 commit intobesu-eth:mainfrom
Solanasol233 wants to merge 1 commit intobesu-eth:mainfrom
Conversation
ddcd2c6 to
da4fb51
Compare
Signed-off-by: Solana Solis <solanasolisss@gmail.com>
da4fb51 to
73be82d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Replace RocksDB retry decisions that relied on exception message text with status-code based checks, and harden retry accounting in
StorageExceptionManager.This change keeps busy-retry handling stable across RocksDB upgrades, avoids throwing when a
StorageExceptionhas no cause, and ensures the retry counter is only incremented for retryable RocksDB statuses. Focused tests cover both the busy-status helper and the retryable error accounting path.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests