Skip to content

Harden RocksDB retry detection and error accounting#10214

Open
Solanasol233 wants to merge 1 commit intobesu-eth:mainfrom
Solanasol233:harden-rocksdb-retry-detection
Open

Harden RocksDB retry detection and error accounting#10214
Solanasol233 wants to merge 1 commit intobesu-eth:mainfrom
Solanasol233:harden-rocksdb-retry-detection

Conversation

@Solanasol233
Copy link
Copy Markdown

PR description

Replace RocksDB retry decisions that relied on exception message text with status-code based checks, and harden retry accounting in StorageExceptionManager.

This change keeps busy-retry handling stable across RocksDB upgrades, avoids throwing when a StorageException has no cause, and ensures the retry counter is only incremented for retryable RocksDB statuses. Focused tests cover both the busy-status helper and the retryable error accounting path.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@Solanasol233 Solanasol233 force-pushed the harden-rocksdb-retry-detection branch from ddcd2c6 to da4fb51 Compare April 10, 2026 08:53
Signed-off-by: Solana Solis <solanasolisss@gmail.com>
@Solanasol233 Solanasol233 force-pushed the harden-rocksdb-retry-detection branch from da4fb51 to 73be82d Compare April 10, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant