Améliore la réutilisabilité des templates d'emails #4966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillett
force-pushed
the
refacto-email
branch
from
5397c1f to
736b4f4
Compare
Shamzic
requested changes
Jan 3, 2026
| @@ -0,0 +1 @@ | |||
| ctaBackgroundColor: "#2aa28bff" | |||
Collaborator
There was a problem hiding this comment.
Ici, la couleur par défaut n'est pas la bonne
Suggested change
| ctaBackgroundColor: "#2aa28bff" | |
| ctaBackgroundColor: "#5770be" |
| install: (app) => { | ||
| const styleElement = document.createElement("style") | ||
| styleElement.textContent = DefaultDsfr | ||
| styleElement.textContent = options[0].value |
Collaborator
There was a problem hiding this comment.
À mes yeux c'est plus clair de laisser le code précédent ici (utilisation explicite du thème par défaut et évite une dépendance implicite du tableau options). Il faudrait probablement faire des modifications pour permettre un thème par défaut paramétrable via une variable defaultTheme)
Suggested change
| styleElement.textContent = options[0].value | |
| styleElement.textContent = DefaultDsfr |
|
|
||
| app.config.globalProperties.$theme = { | ||
| current: Theme.Default, | ||
| current: options[0].label, |
Collaborator
There was a problem hiding this comment.
Dans la continuité du précédent commentaire
Suggested change
| current: options[0].label, | |
| current: Theme.Default, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR empilée sur la précédente #4965