IT-4632 | Fix sub relations when parent has modifier #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvas-damian
reviewed
Oct 5, 2022
|
|
||
| $this->includeParams[$includeName] = $modifierArr; | ||
| if (!isset($this->includeParams[$includeName])) { | ||
| $this->includeParams[$includeName] = $modifierArr; |
There was a problem hiding this comment.
did you consider collecting all values into a list of modifierArr?
Author
There was a problem hiding this comment.
Yeah, but I'm not sure if this is the best design choice. I think it would have to be discussed with upstream. I wanted to limit changes to a bugfix and keep backward compatibility.
kvas-damian
approved these changes
Oct 5, 2022
Author
|
Upstream PR: thephpleague#560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.